Postgres Pro
Downloads
Home   >   mailing lists

Re: An extra error for client disconnection on Windows - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: An extra error for client disconnection on Windows
Date
Msg-id CAJrrPGfNwrnUdD=91pexyEFMAnKWaBQFk-BHTOv2LuOW33Gf1A@mail.gmail.com
Whole thread Raw
In response to An extra error for client disconnection on Windows  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: An extra error for client disconnection on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view


On Thu, Jun 2, 2016 at 6:51 PM, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
Hello.

After a process termination without PQfinish() of a client,
server emits the following log message not seen on Linux boxes.

> LOG:  could not receive data from client: An existing connection was forcibly closed by the remote host.

This is because pgwin32_recv reuturns an error ECONNRESET for the
situation instead of returning non-error EOF as recv(2) does.

This patch translates WSAECONNRESET of WSARecv to an EOF so that
pgwin32_recv behaves the same way with Linux.

The attached patch does this.

I reviewed and verified the changes. This patch works as it stats.
Now there is no extra error message that occurs whenever a client
disconnects abnormally.

Marked the patch as "ready for committer".
 
Regards,
Hari Babu
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: feature request: explain "with details" option
Next
From: Craig Ringer
Date:
Subject: Re: ICU integration