On Sat, Mar 9, 2019 at 2:13 PM Andres Freund <andres@anarazel.de> wrote:
Hi,
While 0001 is pretty bulky, the interesting bits concentrate on a comparatively small area. I'd appreciate if somebody could give the comments added in tableam.h a read (both on callbacks, and their wrappers, as they have different audiences). It'd make sense to first read the commit message, to understand the goal (and I'd obviously also appreciate suggestions for improvements there as well).
I'm pretty happy with the current state of the scan patch. I plan to do two more passes through it (formatting, comment polishing, etc. I don't know of any functional changes needed), and then commit it, lest somebody objects.
I found couple of typos in the committed patch, attached patch fixes them.
I am not sure about one typo, please check it once.
And I reviewed the 0002 patch, which is a pretty simple and it can be committed.
