Re: Enhance pg_stat_wal_receiver view to display connected host - Mailing list pgsql-hackers

From Haribabu Kommi
Subject Re: Enhance pg_stat_wal_receiver view to display connected host
Date
Msg-id CAJrrPGd2NEV=Mjo9CAJj2hgP+uOY76vM9HBofb278J59RMioMg@mail.gmail.com
Whole thread Raw
In response to Re: Enhance pg_stat_wal_receiver view to display connected host  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Enhance pg_stat_wal_receiver view to display connected host  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers

On Thu, Dec 21, 2017 at 11:12 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Thu, Dec 21, 2017 at 8:16 PM, Haribabu Kommi
<kommi.haribabu@gmail.com> wrote:
> The current connected host details are already available in the PGconn
> structure,
> Exposing those details in the view will suffice this requirement. Currently
> these
> members are characters pointers, I used them as it is and displayed them in
> the
> view as character arrays except the port number.
>
> Attached the draft patch. Any comments?

I agree that it would be nice to have an equivalent to
pg_stat_replication's client_addr, client_hostname, client_port on the
receiver side, particularly because it is possible to list multiple
hosts and ports. Could you add that to the next commit fest?

Added.
 
Please note that you need to update rules.out and the documentation
because of the new fields.

Updated patch attached with tests and doc changes.

Regards,
Hari Babu
Fujitsu Australia
Attachment

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: reassure me that it's good to copy pg_control last in a base backup
Next
From: John Naylor
Date:
Subject: Re: WIP: a way forward on bootstrap data