On Mon, Mar 30, 2026 at 8:02 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shlok.
>
> Here are some review comments for the patch v3-0001.
>
> (not yet reviewed the test code)
>
>
> ======
> doc/src/sgml/ref/alter_publication.sgml
>
> synopsis:
>
> 1.
> - [ ONLY ] <replaceable class="parameter">table_name</replaceable> [ * ]
> + TABLE [ ONLY ] <replaceable
> class="parameter">table_name</replaceable> [ * ]
>
> This is still not correct because it is missing the ellipsis that is
> needed within 'except_table_object'. e.g, the currently documented
> synopsis would not permit FOR ALL TABLE EXCEPT (TABLE t1,t2,t3);
>
> You might describe that using one of these ways:
>
> i)
> TABLE { [ ONLY ] table_name [ * ] } [, ...]
>
But isn't '{' is used to indicate a group of options, usually combined
with | to show choices. Examples:
TABLES IN SCHEMA { schema_name | CURRENT_SCHEMA } [, ... ]
ALTER PUBLICATION name OWNER TO { new_owner | CURRENT_ROLE |
CURRENT_USER | SESSION_USER }
In our case, I don't see such an option list. Let me know if I have
misunderstood.
thanks
Shveta
