Re: Simplify code building the LR conflict messages - Mailing list pgsql-hackers

From shveta malik
Subject Re: Simplify code building the LR conflict messages
Date
Msg-id CAJpy0uCfh7gxSQryfHqhdjrrxZ2Ki7T_us9=RNiTiNt3ueCN4w@mail.gmail.com
Whole thread Raw
In response to RE: Simplify code building the LR conflict messages  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
On Wed, Jan 21, 2026 at 7:52 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear hackers,
>
> Thanks for the comment. I fixed a whitespace issue. I attach only 0001 to focus on it.
> Also, Hou Zhijie gave a comment to improve the code comment (maybe it's under
> moderation). His point is that get_tuple_ function can also append the description
> for each attribute and append_tuple_value_detail() can handle lists of them.
> I've updated based on this, taking into account the lack of permissions.
>
> How do you think?
>

The function re-structuring looks good. No issues observed in my local
testing. Thus the patch LGTM.

thanks
Shveta



pgsql-hackers by date:

Previous
From: Henson Choi
Date:
Subject: Re: Row pattern recognition
Next
From: Chao Li
Date:
Subject: tablecmds: reject CLUSTER ON for partitioned tables earlier