Please find a few comments on 003:
1)
+#include "replication/logicallauncher.h"
+#include "replication/origin.h"
+#include "replication/slot.h"
syncutils.c compiles without these 3 inclusions.
2)
Should 'table_states_not_ready' be changed to
'relation_states_not_ready' as now it handles both tables and
sequences?
3)
invalidate_syncing_table_states has been changed to
InvalidateRelationStates. Shall we keep it as
InvalidateSyncingRelStates()?
4)
getSubscriptionTables:
- * Get information about subscription membership for dumpable tables. This
+ * Get information about subscription membership for dumpable relations. This
Is there a reason that we have changed the comment but not the function name?
thanks
Shveta
