Re: A new C function `get_partition_root`. - Mailing list pgsql-hackers

From shveta malik
Subject Re: A new C function `get_partition_root`.
Date
Msg-id CAJpy0uBjUY5JFYFrHvpzBH_OSt90J3uRi5NHaN6yutmcYa3m5w@mail.gmail.com
Whole thread
In response to Re: A new C function `get_partition_root`.  (shveta malik <shveta.malik@gmail.com>)
List pgsql-hackers
On Thu, Jul 30, 2026 at 5:35 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> On Wed, Jul 29, 2026 at 7:18 PM shveta malik <shveta.malik@gmail.com> wrote:
> >
> > On Wed, Jul 29, 2026 at 2:28 PM Peter Smith <smithpb2250@gmail.com> wrote:
> ...
> > > BTW, although I think using sanity Assert was correct, just in case
> > > there is some unanticipated way to reach the C function with a bad
> > > relid, I've changed to use an errlog(ERROR).
> > > Thoughts?
> >
> > I don't immediately see any such possibility. I feel Assert is better.
> >
>
> OK. PSA v4, which is the same as v3, but uses Assert instead of elog.
>

Looks good.

thanks
Shveta



pgsql-hackers by date:

Previous
From: shihao zhong
Date:
Subject: Re: lazy_scan_heap: avoid vacuum block, already vacuumed (src/backend/access/heap/vacuumlazy.c)
Next
From: Chao Li
Date:
Subject: Re: question about is_valid parameter in set_attnotnull