Re: Proposal: Conflict log history table for Logical Replication - Mailing list pgsql-hackers

On Wed, Aug 12, 2026 at 9:13 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
>
> Changed.
>

Thanks Dilip. A few trivial comments on v69:

1)
+insert_conflict_log_tuple(Relation conflictlogrel, HeapTuple tuple)
+{
+ Assert(tuple != NULL);
+
+ heap_insert(conflictlogrel, tuple,
+ GetCurrentCommandId(true), 0, NULL);
+}

Should we get rid of this function now?
a) It does not do anything extra other than heap_insert()
b) There is only one caller.

2)
LOG:  conflict detected on relation "public.tab1": conflict=delete_missing
DETAIL:  Conflict details are logged to the conflict log table:
pg_conflict_log_16390

It will be good to specify schema qualified name here:
pg_conflict.pg_conflict_log_16390, as we do at other places.


3)
The doc page shows:

29.8.1. Conflict logging
29.8.2. Table-based logging
29.8.3. File-based logging
29.8.4. Notes

Should it be:
29.8.1. Conflict logging
    29.8.1.1. Table-based logging
    29.8.1.2. File-based logging
29.8.2. Notes

What do you say?

thanks
Shveta