Re: [Proposal] Adding Log File Capability to pg_createsubscriber - Mailing list pgsql-hackers

From shveta malik
Subject Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date
Msg-id CAJpy0uBPvz6S9VE8sLYmoju4BGYh94uks+UTocPdD094xqmZ2w@mail.gmail.com
Whole thread Raw
In response to Re: [Proposal] Adding Log File Capability to pg_createsubscriber  (Gyan Sreejith <gyan.sreejith@gmail.com>)
Responses Re: [Proposal] Adding Log File Capability to pg_createsubscriber
List pgsql-hackers
On Mon, Mar 16, 2026 at 4:53 AM Gyan Sreejith <gyan.sreejith@gmail.com> wrote:
>
>
> Thank you! I have attached the changes.

Thank You for the patch.

1)
 I observed that when we give both --verbose and --logdir options, it
skips verbose and only dumps logs to logdir. Is this intentional?

I don't see any other postgres command with both the options provided
and thus cannot compare the behaviour. But IMO, if the user has
explicitly given both options, we should dump the log on both (stdout
and logfile). Thoughts?  (Apologies if this has already been discussed
and I missed it.)

2)
I noticed a minor difference when running the command with both
--verbose and --logdir, depending on the order in which they are
specified.

If --verbose is specified first, I see the following message on the console:
pg_createsubscriber: directory ../../pg_createsub/20260317T112204.848 created

But if --logdir is specified first, this message does not appear on
the console. Is this behavior intentional?

thanks
Shveta



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)
Next
From: Chao Li
Date:
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier