Request a Demo
Home   >   mailing lists

Re: [Proposal] Adding Log File Capability to pg_createsubscriber - Mailing list pgsql-hackers

From shveta malik
Subject Re: [Proposal] Adding Log File Capability to pg_createsubscriber
Date
Msg-id CAJpy0uAwPNG3GN5+jTajnccLe+F1mW6dZh-9112u3QQQYugA=Q@mail.gmail.com
Whole thread
In response to Re: [Proposal] Adding Log File Capability to pg_createsubscriber  (Gyan Sreejith <gyan.sreejith@gmail.com>)
Responses Re: [Proposal] Adding Log File Capability to pg_createsubscriber
List pgsql-hackers
Tree view 
On Sun, Mar 22, 2026 at 4:39 AM Gyan Sreejith <gyan.sreejith@gmail.com> wrote:
>
>
> On Sat, Mar 21, 2026 at 5:57 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>>
>> Based on the above information, can we consider renaming the above
>>
>> functions to report_createsub_log() and report_createsub_fatal()?
>>
>> Other than the above point, 0001 LGTM.
>
>
> I have renamed the functions.
>

001 looks good. I like the new function's name.
Commit message still refers old function name, it can be corrected
during commit.

thanks
Shveta

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_waldump: support decoding of WAL inside tarfile
Next
From: Tom Lane
Date:
Subject: Re: TupleDescAttr bounds checks