Request a Demo
Home   >   mailing lists

Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE - Mailing list pgsql-hackers

From shveta malik
Subject Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE
Date
Msg-id CAJpy0uApaWwXUrjP+FqcYmVG7bnS-u2WWvchwvr8u6d47RxT0w@mail.gmail.com
Whole thread
In response to Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE  (Ajin Cherian <itsajin@gmail.com>)
Responses Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE
List pgsql-hackers
Tree view 
On Wed, Apr 29, 2026 at 7:12 AM Ajin Cherian <itsajin@gmail.com> wrote:
>
> On Wed, Apr 29, 2026 at 12:17 AM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> >
> >
> >
> > Please find the attached v4 patch. Thank yoU!
> >
>
> One small comment. The includes need to be in alphabetical order.
> injection_point.h should come after fmgroids.h
>
>  #include "utils/fmgroids.h"
>  #include "utils/lsyscache.h"
>  #include "utils/rel.h"
> +#include "utils/injection_point.h"
>  #include "utils/syscache.h"
>

+1

Also there is a trailing whitespace issue while applying the patch.
Other than these, the patch looks good.

thanks
Shveta

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: New vacuum config to avoid anti wraparound vacuums
Next
From: Dilip Kumar
Date:
Subject: Re: Support logical replication of DDLs, take2