Re: Review items for EXCEPT TABLE publication - Mailing list pgsql-hackers

From shveta malik
Subject Re: Review items for EXCEPT TABLE publication
Date
Msg-id CAJpy0uAD1Ds1QDjXnZR_xxTy5f7Od0o5mMmEL9MLwAvT67=o0A@mail.gmail.com
Whole thread
Responses Re: doc: REPACK is missing from the MAINTAIN privilege documentation
List pgsql-hackers
patch 002:

Commit msg says:
----------
The command then re-fetches the publication tuple after acquiring the
lock, but does not revalidate the publication relations. This can leave
pg_publication_rel containing a mixture of inclusion and exclusion rows.

Re-run CheckAlterPublication() after acquiring the lock so that the
validation uses the current publication state.
---------

The commit message and the fix are not in sync and thus little
confusing. Commit msg talks about re-validation while patch has
shifted the validation to a later point. The code change looks good
though.


patch003: LGTM

patch004: LGTM

thanks
Shveta



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: remove_useless_joins vs. bug #19560
Next
From: Ashutosh Bapat
Date:
Subject: Re: PGQ catalog representation and pg_dump support