Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases - Mailing list pgsql-bugs

From Andrew Bille
Subject Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases
Date
Msg-id CAJnzarzpALeGtF-1VPoLa5=52BoixpVPE9BzrxbnPbtAw741jg@mail.gmail.com
Whole thread Raw
In response to Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases
List pgsql-bugs
Looks good for me. I checked it on my enhanced upgrade test.

Thanks.

Regards,
Andrew

On Mon, Oct 6, 2025 at 7:04 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
I think we can fix it in getTableAttrs(), see attached, with that I
can see my dump is correct.  This is just a quick way to show what I
am thinking, maybe we can improve this condition.  I believe
flagInhAttrs() is more about resetting the "notnull_islocal" if any of
the parent already has it as non null.  This fix is working with this
basic case, but I haven't investigated whether it will work in all
cases or is it breaking anything.

--
Regards,
Dilip Kumar
Google

pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: Segfault in RI UPDATE CASCADE on partitioned tables with LIKE+ATTACH child (attnum drift)
Next
From: Bo Peng
Date:
Subject: Re: Automating Failover Resync & Re-Attach in pgpool2