Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values - Mailing list pgsql-hackers

From Greg Nancarrow
Subject Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values
Date
Msg-id CAJcOf-efwmBCwDp7nROFWk8W8TT=3h-n=GVncc3q5RO_-qjnyA@mail.gmail.com
Whole thread Raw
In response to Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Remove useless int64 range checks on BIGINT sequence MINVALUE/MAXVALUE values  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, Jul 12, 2021 at 2:26 PM David Rowley <dgrowleyml@gmail.com> wrote:
>
> > It seems strange to add a comment to explain why it's there. If we're
> > going to the trouble of doing that, then we should just remove it and
> > add a very small comment to mention why INT8 sequences don't need to
> > be checked.
>
> Any thoughts on this, Greg?
>

The patch LGTM (it's the same as my original patch but with short comments).

Regards,
Greg Nancarrow
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: row filtering for logical replication
Next
From: Amul Sul
Date:
Subject: Re: [CLOBBER_CACHE]Server crashed with segfault 11 while executing clusterdb