Re: [PATCH] Optimize SP-GiST text leaf comparisons with memcmp - Mailing list pgsql-hackers

From James Hunter
Subject Re: [PATCH] Optimize SP-GiST text leaf comparisons with memcmp
Date
Msg-id CAJVSvF4YLOMWUVMD7P_LgZQQvZK7MyPLtD-K3aJyCCOPESjjPQ@mail.gmail.com
Whole thread Raw
List pgsql-hackers
On Wed, Feb 12, 2025 at 5:14 PM ahmedashour <a8087027@gmail.com> wrote:
>
> Thank you for your feedback and review! I have addressed the comments and updated the patch accordingly. Below are
thedetails of the changes: 
>
> Please review the updated patch and let me know if there are any further issues or suggestions for improvement.

The patch has a lot of whitespace diffs -- were these intentional? If
you run "pgindent" on your change, before creating a patch, that tool
will normalize the whitespace to PostgreSQL coding standard.

For example, attached is your patch, but with "pgindent" run on it
first. So the patch / diff is much smaller now.

James

Attachment

pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Log connection establishment timings
Next
From: Jeff Davis
Date:
Subject: Re: Statistics Import and Export