Re: inconsistency and inefficiency in setup_conversion() - Mailing list pgsql-hackers

From John Naylor
Subject Re: inconsistency and inefficiency in setup_conversion()
Date
Msg-id CAJVSVGXE8+Wq_SHZ5KJF+6t=pHJf=ySO645aBomw-nSCxhBx0Q@mail.gmail.com
Whole thread Raw
In response to Re: inconsistency and inefficiency in setup_conversion()  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: inconsistency and inefficiency in setup_conversion()  (John Naylor <jcnaylor@gmail.com>)
List pgsql-hackers
On 5/19/18, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
> Looks good on Windows[1] but now it's broken on Linux[2] (also
> reproducible on my macOS laptop):

That's what happens when I squeeze in a small Makefile change without
testing the build. Fix attached. Thanks again and sorry for the noise.

(In case I didn't mention previously, the Perl script is for
visibility; reviewers/committers don't need to run it.)

-John Naylor

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Postgres, fsync, and OSs (specifically linux)
Next
From: John Naylor
Date:
Subject: FindDefinedSymbol() is subtly broken