Re: wrapping in extended mode doesn't work well with default pager - Mailing list pgsql-hackers

From Sergey Muraviov
Subject Re: wrapping in extended mode doesn't work well with default pager
Date
Msg-id CAJTaR30TuhZOJQpT=yLDmgdg5s8dt9S79p-8qm2dx2Bzsy1LHA@mail.gmail.com
Whole thread Raw
In response to Re: wrapping in extended mode doesn't work well with default pager  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: wrapping in extended mode doesn't work well with default pager  (Sergey Muraviov <sergey.k.muraviov@gmail.com>)
List pgsql-hackers
Hi.

I'll try to fix it tomorrow.


2014-05-12 18:42 GMT+04:00 Tom Lane <tgl@sss.pgh.pa.us>:
Greg Stark <stark@mit.edu> writes:
> On Mon, May 12, 2014 at 2:12 PM, Greg Stark <stark@mit.edu> wrote:
>> Hm, there was an off by one error earlier in some cases, maybe we
>> fixed it by breaking other case. Will investigate.

> Those spaces are coming from the ascii wrapping indicators. i.e. the periods in:

Ah.  I wonder whether anyone will complain that the format changed?

> Apparently we used to print those with border=1 in normal mode but in
> expanded mode we left out the space for those on the outermost edges
> since there was no need for them. If we put them in for wrapped mode
> then we'll be inconsistent if we don't for nonwrapped mode though. And
> if we don't put them in for wrapped mode then there's no way to
> indicate wrapping versus newlines.

Barring anyone complaining that the format changed, I'd say the issue
is not that you added them but that the accounting for line length
fails to include them.

                        regards, tom lane



--
Best regards,
Sergey Muraviov

pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Running DBT2 on postgresql
Next
From: Christoph Berg
Date:
Subject: New timezones used in regression tests