Request a Demo
Home   >   mailing lists

Re: Wrong results in remove_useless_groupby_columns() - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: Wrong results in remove_useless_groupby_columns()
Date
Msg-id CAJTYsWXpUzj3hn7RZi30t57gQ499JSp=2oW8AVOqJA=WZ_YLCw@mail.gmail.com
Whole thread
In response to Re: Wrong results in remove_useless_groupby_columns()  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Wrong results in remove_useless_groupby_columns()
List pgsql-hackers
Tree view
Hi,


On Fri, 8 May 2026 at 05:46, Richard Guo <guofenglinux@gmail.com> wrote:
On Tue, May 5, 2026 at 7:12 PM Richard Guo <guofenglinux@gmail.com> wrote:
> Attached patch fixes both issues.

I plan to push and back-patch this shortly, as the code freeze for the
stable branches is just around the corner.

- Richard


I reviewed the patch and it looks good to me.

The added opfamily and collation checks seem consistent with the uniqueness
proof used in relation_has_unique_index_for(), and the tests cover both
reported wrong-result cases.

Applied the patch, ran tests, they passed.

Regards,
Ayush

pgsql-hackers by date:

Previous
From: "cca5507"
Date:
Subject: Re: Call EndCopyFrom() after initial table sync in logical replication
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication