> and moves a > ReleaseSysCache() call before an ERROR ereport in > check_element_properties(). > > The existing code should be cleaned up by > the resource owner on the ERROR path, but the explicit ReleaseSysCache() > placed after ereport(ERROR) was unreachable.
I think that's fine. I don't think the change makes this better.
IIUC that is dead code right now, it never reaches that point to release?
