Request a Demo
Home   >   mailing lists

Re: remove VersionedQuery support from psql tab completion - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: remove VersionedQuery support from psql tab completion
Date
Msg-id CAJTYsWWAinjQ3K22H5f8Lq_k_2GsunzeHcndScs+gG-xKB3VCA@mail.gmail.com
Whole thread
In response to remove VersionedQuery support from psql tab completion  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view
Hi,

On Fri, 3 Jul 2026 at 00:21, Nathan Bossart <nathandbossart@gmail.com> wrote:
This infrastructure was added by commit 722408bcd1 and was only ever used
for publications and subscriptions.  Since we just bumped psql's minimum
supported version to v10, it's no longer used by anything.  Furthermore, a
quick glance indicates there's nothing else that should use it.  So, IMHO
we might as well remove it.

Thanks for the patch!

Doing a grep on VersionedQuery I could find one instance missing
in your patch in 010_tab_completion.pl file there's a test block 

# check VersionedQuery infrastructure
check_completion(
    "DROP PUBLIC\t \t\t",
    qr/DROP PUBLICATION\s+some_publication /,
    "check VersionedQuery"); 

I think the test case is fine, but the comment + label needs to be
updated or case drop if it's redundant.

Rest, LGTM.

Regards,
Ayush

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Announcing Release 21 of the PostgreSQL Buildfarm Cient
Next
From: Pavel Stehule
Date:
Subject: Re: proposal - queryid can be used as filter for auto_explain