Re: [PATCH] Table sync race with REFRESH PUBLICATION - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: [PATCH] Table sync race with REFRESH PUBLICATION
Date
Msg-id CAJTYsWVF-rr4mdtck5Bx_MwH=VhKuPPFc+UVVL0nV1JnJrEQog@mail.gmail.com
Whole thread
In response to Re: [PATCH] Table sync race with REFRESH PUBLICATION  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: [PATCH] Table sync race with REFRESH PUBLICATION
List pgsql-hackers
Hi,

On Tue, 29 Sept 2026 at 07:30, Peter Smith <smithpb2250@gmail.com> wrote:
>
> > Attached is v2 with those changes. Thoughts?
> >
>
> Hi Ayush.
>
> //////////
> Patch v2-0001
> //////////
>
> Patch 0001 looks good to me, but more eyes than mine need to review it.

Thanks for the review!

>
> //////////
> Patch v2-0002
> //////////
>
> I confirmed the test fails when patch 0001 is not applied and passes
> when it is applied.
>
> I assume the test code is AI-generated, because it looks way less
> human-readable than a typical TAP test. If the test is ever intended
> to be pushed, then it needs lots of comments to describe what it is
> doing and expecting at each step.

I do not intend this to be pushed since as I stated upthread its
a niche case that came out of manual review rather than field report.

I'll post a simplified version in some time for the same, thanks
for looking into it.

Regards,
Ayush



pgsql-hackers by date:

Previous
From: "Chee Wooson"
Date:
Subject: Re: Re: [PATCH] Discard aborted updaters when expanding a multixact
Next
From: Nikhil Kumar Veldanda
Date:
Subject: Re: ZSTD TOAST compression, and an extensible compression method encoding