Re: plpython: NULL pointer dereference on broken sequence objects - Mailing list pgsql-hackers

From Ayush Tiwari
Subject Re: plpython: NULL pointer dereference on broken sequence objects
Date
Msg-id CAJTYsWV4PhH=mhs9KuTLyL4YSOfbuUM1E22K91osDQVsxQu-Og@mail.gmail.com
Whole thread
In response to Re: plpython: NULL pointer dereference on broken sequence objects  (Richard Guo <guofenglinux@gmail.com>)
List pgsql-hackers
Hi,

On Fri, 26 Jun 2026 at 11:35, Richard Guo <guofenglinux@gmail.com> wrote:
On Thu, Jun 25, 2026 at 10:05 PM Ayush Tiwari
<ayushtiwari.slg01@gmail.com> wrote:
> I think there's a similar problem on the mapping side that v1 doesn't
> cover. PLyMapping_ToJsonbValue and the hstore equivalent fetch items with
> PyMapping_Items() and PyList_GetItem() without checking for NULL, and a
> mapping whose items() raises still would crash the backend.

Right.  Those functions have the same issue as PySequence_GetItem().
The attached v2 patch fixes them all.

Thanks for the update! v2 LGTM.
 
Regards,
Ayush

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks