$result = $node_publisher->safe_psql('postgres', "SELECT * FROM tab1 ORDER BY a"); is( $result, qq(1 2), "check replication of a table in the EXCEPT clause of one publication but included by another" );
In 037_except.pl, this query is executed on the publisher. But, if the intent is to verify that rows inserted on the publisher are replicated to the subscriber, shouldn't this query be executed on the subscriber instead? IOW, should "$node_publisher" here be "$node_subscriber"? Or am I missing something?
Yeah you're right, it should likely be the subscriber.
Same issue appears twice (the "FOR TABLE" and "FOR ALL TABLES" cases); both need the change.
