> The attached patch rejects the explicit ENCODING option for JSON > mode, consistent with how DELIMITER, NULL, DEFAULT, and HEADER are > already rejected.
Given that we reject other incompatible parameters it makes sense to reject this one as well, however I think we can expand the comment a little and explain why.
Thanks Daniel. Agreed, v2 attached with an expanded comment explaining why the option is rejected, I've tried to make it small, because rest
rejected ones did not have relevant comments.
/* * Reject ENCODING for JSON format. JSON output is produced as * a whole by composite_to_json(), so the per-attribute encoding * conversion done for text and CSV output is not applied. */