missing PG_FREE_IF_COPY in textlike() and textnlike() ? - Mailing list pgsql-hackers

From CK Tan
Subject missing PG_FREE_IF_COPY in textlike() and textnlike() ?
Date
Msg-id CAJNt7=ZeciAZAgH03MSTPwo2cD5ROSnpo9+xwoA7SrPYMpjJ9A@mail.gmail.com
Whole thread Raw
Responses Re: missing PG_FREE_IF_COPY in textlike() and textnlike() ?
List pgsql-hackers
Hi Hackers,

I see in the texteq() function calls to DatumGetTextPP() are followed
by conditional calls to PG_FREE_IF_COPY. e.g.

https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/varlena.c#L1792

   text *targ1 = DatumGetTextPP(arg1);
   text *targ2 = DatumGetTextPP(arg2);
   result = (memcmp(VARDATA_ANY(targ1), VARDATA_ANY(targ2), len1 -
VARHDRSZ) == 0);
   PG_FREE_IF_COPY(targ1, 0);
   PG_FREE_IF_COPY(targ2, 1);

However, in textlike(), PG_FREE_IF_COPY calls are missing.

https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/like.c#L283

Is this a memory leak bug?

Regards,
-cktan



pgsql-hackers by date:

Previous
From: bt22nakamorit
Date:
Subject: Make ON_ERROR_STOP stop on shell script failure
Next
From: Amit Kapila
Date:
Subject: Re: A question about wording in messages