GiST: interpretation of NaN from penalty function - Mailing list pgsql-hackers

From Andrew Borodin
Subject GiST: interpretation of NaN from penalty function
Date
Msg-id CAJEAwVFxCbEYM157McVqQrvg7CQthxF2UdXw0sZCjLvW7cekQw@mail.gmail.com
Whole thread Raw
Responses Re: GiST: interpretation of NaN from penalty function  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi hackers!

Currently GiST treats NaN penalty as zero penalty, in terms of
generalized tree this means "perfect fit". I think that this situation
should be considered "worst fit" instead.
Here is a patch to highlight place in the code.
I could not construct test to generate bad tree, which would be fixed
by this patch. There is not so much of cases when you get NaN. None of
them can be a result of usual additions and multiplications of real
values.

Do I miss something? Is there any case when NaN should be considered good fit?

Greg Stark was talking about this in
BANLkTi=d+bPpS1cM4YC8KuKHj63Hwj4LMA@mail.gmail.com but that topic
didn't go far (due to triangles). I'm currently messing with floats in
penalties, very close to NaNs, and I think this question can be
settled.

Regrads, Andrey Borodin.

Attachment

pgsql-hackers by date:

Previous
From: Andrew Borodin
Date:
Subject: Re: GiST penalty functions [PoC]
Next
From: Alvaro Herrera
Date:
Subject: Re: Vacuum: allow usage of more than 1GB of work mem