Hi,
On Mon, Jan 5, 2026 at 1:25 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Amit,
>
> >
> > I think it is better if we add some comments atop
> > ReplicationSlotAlter() as you are suggesting. What do you think of the
> > attached?
>
> Thanks for attaching the patch. There is a small typo:
>
> > + * clinet-side. Enabling it at any random point during decoding has the
>
> "clinet" should be client. Others are OK for me.
>
Thank you all for your comments!
I agree with suggested fixes. Please, see them in the attached patch.
On Mon, Jan 5, 2026 at 2:56 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Amit,
>
> While reviewing your change, I find the other typo in slot.c:
> ```
> - /* Check if the slot exits with the given name. */
> + /* Check if the slot exists with the given name. */
> s = SearchNamedReplicationSlot(name, false);
> if (s == NULL || !s->in_use)
> ```
>
> “Exits” and “exists” have totally different meanings, thus might lead to misunderstanding. Attached is a trivial diff
tofix that.
>
Good catch!
I am not sure that we should put both fixes together, so I'll put your fix in a
separate patch.
--
Best regards,
Daniil Davydov
