Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react - Mailing list pgadmin-hackers

From Pradip Parkale
Subject Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react
Date
Msg-id CAJ9T6Stg_oyc6aOpj=c4kOZYmuM3OjBLow-tUyT68-fD+PmPAQ@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgAdmin][RM6677 & RM6632] [React] Port Procedure and Function node to react
List pgadmin-hackers
Hi Akshay,

Please find the attached patch for #6838 and #6841.
Issues are:
  1. System procedure should not be visible in the properties tab for function.
  2. Estimated cost option should be editable in edit mode for Procedure.
  3. Should give an error when language is not specified.

On Thu, Aug 26, 2021 at 12:22 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On Thu, Aug 26, 2021 at 11:53 AM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,

Please find the attached patch. I have improved the code coverage of Function node and also fixed the test cases which were failing for Cast ,Subscription and Publication node.

On Tue, Aug 24, 2021 at 10:54 AM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for RM6677 and RM6632 [React] Port Procedure and Function node to react.

Also Updated a few test cases for previous ported nodes.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [patch][pgAdmin] RM6744 Unable to delete rows for Enum type in Create Type dialogue
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Ensure that the 'When' field should be read-only in t