Re: [PATCH] Simplify SortSupport implementation for macaddr - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Simplify SortSupport implementation for macaddr
Date
Msg-id CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Simplify SortSupport implementation for macaddr  (Andrey Borodin <x4mmm@yandex-team.ru>)
Responses Re: [PATCH] Simplify SortSupport implementation for macaddr
List pgsql-hackers
Hi Andrey,

Many thanks for your feedback!

> 1. The assignment ssup->ssup_extra = NULL can be removed. The
>    SortSupport struct is zeroed before the callback is called (see
>    sortsupport.h). There are about 22 similar assignments elsewhere;
>    it does not seem to be established practice, many other places have
>    no such assignment.

Agree. I removed this assignment in 0001 and added 0002 that removes
if for the rest of *_sortsupport() functions.

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pg_combinebackup: incorrect size of VM fork after combine
Next
From: Robert Haas
Date:
Subject: Re: Consider low startup cost in add_partial_path