Hi Jacob,
Thanks for the bug report and the fix.
> [...]
>
> It seems that using page locks here would require some additional notion of heap gap locking, or corresponding
changesto the insert conflict checks. With the existing predicate-locking scheme, I think the relation lock is needed
tocover inserts as well as updates.
Yes it looks like an architecturally correct approach with minimum
overall overhead. In any case anyone who wants to implement an
optimization can submit it as a separate patch.
My only nitpick is that the patch doesn't update README-SSI. The
corrected patch is attached. Also I added a proper commit message.
I believe the patch is Ready for Committer.
--
Best regards,
Aleksander Alekseev