Re: Write skew observed under serializable isolation - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Write skew observed under serializable isolation
Date
Msg-id CAJ7c6TPjccw9zdDotmL_Fsr9MmFrp-n=A+k=rH1ANAkkjxoBCQ@mail.gmail.com
Whole thread
In response to Re: Write skew observed under serializable isolation  (Jacob Brazeal <jacob.brazeal@gmail.com>)
Responses Re: Write skew observed under serializable isolation
List pgsql-hackers
Hi Jacob,

Thanks for the bug report and the fix.

> [...]
>
> It seems that using page locks here would require some additional notion of heap gap locking, or corresponding
changesto the insert conflict checks. With the existing predicate-locking scheme, I think the relation lock is needed
tocover inserts as well as updates. 

Yes it looks like an architecturally correct approach with minimum
overall overhead. In any case anyone who wants to implement an
optimization can submit it as a separate patch.

My only nitpick is that the patch doesn't update README-SSI. The
corrected patch is attached. Also I added a proper commit message.

I believe the patch is Ready for Committer.

--
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Re: Stabilize and shorten test_checksums/013_rewind test
Next
From: Aleksander Alekseev
Date:
Subject: Re: Open SSI correctness issues