Hi Daniel,
> Online enabling and disabling of data checksums
>
> [...]
I noticed a little mistake:
```
/*
* Await state transition to "on" in all backends. When done we know that
* data data checksums are both written and verified in all backends.
*/
```
The word "data" is repeated twice.
Also there are inconsistencies in the way
XLogCtlData->data_checksum_version,
ControlFileData->data_checksum_version and certain variables are
assigned. Sometimes a hardcoded 0 is used and sometimes
PG_DATA_CHECKSUM_OFF. I suggest using values of the enum
ChecksumStateType for readability / consistency.
Here are corresponding patches.
--
Best regards,
Aleksander Alekseev
