Re: pg_resetwal tests, logging, and docs update - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: pg_resetwal tests, logging, and docs update
Date
Msg-id CAJ7c6TPL0kDwoDwcgChZTce+P_68mzVg_-viBrc7bCQyP5jwuw@mail.gmail.com
Whole thread Raw
In response to Re: pg_resetwal tests, logging, and docs update  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pg_resetwal tests, logging, and docs update
List pgsql-hackers
Hi,

> Here are updated versions of the remaining patches.  I took out the
> "FIXME" notes about the multipliers applying to the -c option and
> replaced them by gentler comments.  I don't intend to resolve those
> issues here.

The patch LGTM. However, postgresql:pg_resetwal test suite doesn't
pass on Windows according to cfbot. Seems to be a matter of picking a
more generic regular expression:

```
at C:/cirrus/src/bin/pg_resetwal/t/001_basic.pl line 54.
                'pg_resetwal: error: could not change directory to
"foo": No such file or directory
  doesn't match '(?^:error: could not read permissions of directory)'
```

Should we simply use something like:

```
qr/error: could not (read|change).* directory/
```

... instead?

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Open a streamed block for transactional messages during decoding
Next
From: "Anton A. Melnikov"
Date:
Subject: Re: Some performance degradation in REL_16 vs REL_15