Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
Date
Msg-id CAJ7c6TPD=6Zx7+xWC8y5HMeH_K6NxkKb8OkX0iy8Rs2Lk-957Q@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: [PATCH] Replace magic constant 3 with NUM_MERGE_MATCH_KINDS
List pgsql-hackers
Tree view 
Hi,

> I guess the argument against inserting an enum element at the end is
> that a switch statement on the enum value might generate a compiler
> warning if it didn't have a default clause.

Fair point. PFA the alternative version of the patch.

-- 
Best regards,
Aleksander Alekseev
Attachment

pgsql-hackers by date:

Previous
From: Sriram RK
Date:
Subject: Re: AIX support
Next
From: shveta malik
Date:
Subject: Re: promotion related handling in pg_sync_replication_slots()