Re: [PATCH] Remove make_temptable_name_n() - Mailing list pgsql-hackers

Hi Shinya,

Thanks for your feedback.

> The v1 revision removed make_temptable_name_n and added psprintf,
> which reduced the code size. However, the code size in v3 is almost
> unchanged, so it's unclear how beneficial this change actually is.

Right, the concept has changed a bit, see Álvaro's comment above.

> Anyway, I have a minor comment about the patch.
>
> + char* nsp = get_namespace_name(RelationGetNamespace(tempRel));
> + char* temprelname = RelationGetRelationName(tempRel);
> + char* diffrelname = psprintf("%s_%d", temprelname, 2);
>
> In PostgreSQL code, "char *xxx" seems to be more commonly used than "char* xxx".

My bad, I forgot to run pgindent. Here is the corrected patch.

--
Best regards,
Aleksander Alekseev