Re: [PATCH] Miscellaneous little fixes - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Miscellaneous little fixes
Date
Msg-id CAJ7c6TOSsHZY14wNYxk4DRr01wvaQ9fwS=W3Zbpt7B84TNyWig@mail.gmail.com
Whole thread
In response to Re: [PATCH] Miscellaneous little fixes  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi Michael,

Thanks for picking this up.

> There is no cost in keeping it, and removing it could break some
> extension code out there..

Of course it's up to you to decide, but I wanted to point out the
comment written in 2014 says:

/* Remove me eventually */

... soooooo. IMO 12 years is quite enough for eventually and for a
line of code that is not covered by any tests :)

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Add missing period to DETAIL messages
Next
From: "胡传文"
Date:
Subject: [PATCH] Fix wrong comment in JsonTablePlanJoinNextRow()