Re: use the malloc macros in pg_dump.c - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: use the malloc macros in pg_dump.c
Date
Msg-id CAJ7c6TOJVfBf-QZP3RvNMbHQKzgKA9Vkd6g34ZMxd-LqGKoRUA@mail.gmail.com
Whole thread Raw
In response to use the malloc macros in pg_dump.c  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: use the malloc macros in pg_dump.c
List pgsql-hackers
Hi Peter,

> I found that pg_dump.c has many pg_mallocs where the new object/array
> macros could have been used, but currently they are not. I'm not sure
> if this was a deliberate or accidental omission.
>
> In case it was accidental, here is a patch to modify/simplify all that
> allocation code.

Thanks for the patch. I reviewed / tested it and it looks OK. This
being said, I see many pieces of code left that still use pg_malloc /
pg_realloc in a similar fashion, including src/bin/pg_dump/* files.
Would you like to address those as well, or keep the scope only to
pg_dump.c?

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Rahila Syed
Date:
Subject: Re: Enhancing Memory Context Statistics Reporting
Next
From: Tatsuya Kawata
Date:
Subject: Re: [PATCH] ANALYZE: hash-accelerate MCV tracking for equality-only types