Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions
Date
Msg-id CAJ7c6TNzQES3EhzoftNUEg=mfi69SYEQ=Fh-=rr84b7zHECHeg@mail.gmail.com
Whole thread
In response to Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions  (Aleksander Alekseev <aleksander@tigerdata.com>)
Responses Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions
List pgsql-hackers
Hi,

> > Also, a small nitpick is that we can use uint32 instead of uint64 for
> > 'bits_buffer'. I've attached the updated patch as well as the
> > difference from the previous version.
>
> Then I suggest using uint32 for the bits_buffer variable in
> base32hex_encode() too. Also we should use 1U instead of 1ULL with
> uint32.

CI is not happy with the new test:

```
 SELECT decode('あ', 'base32hex'); -- error
-ERROR:  invalid symbol "あ" found while decoding base32hex sequence
+ERROR:  invalid symbol "ã" found while decoding base32hex sequence
```

Although it passes locally. My best guess is that something is off
with the database encoding on CI and that we shouldn't use this test.
We have a similar test which uses ASCII symbols only.

--
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: feature freeze for v19 begins April 8th at 12:00 UTC
Next
From: Nitin Jadhav
Date:
Subject: Re: Change checkpoint‑record‑missing PANIC to FATAL