Re: [PATCH] Add crc32(text) & crc32(bytea) - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Add crc32(text) & crc32(bytea)
Date
Msg-id CAJ7c6TNLbjr5tF11J6eKQOYGW3c_ztE_G8-BvmjU3QCJiSjLkA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add crc32(text) & crc32(bytea)  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: [PATCH] Add crc32(text) & crc32(bytea)
List pgsql-hackers
Hi,

> I'm curious why we need to do this instead of only using the macros:
>
>     INIT_TRADITIONAL_CRC32(crc);
>     COMP_TRADITIONAL_CRC32(crc, VARDATA_ANY(in), len);
>     FIN_TRADITIONAL_CRC32(crc);
>
> + * IDENTIFICATION
> + *    src/backend/utils/adt/hashfuncs.c
>
> Perhaps these would fit into src/backend/utils/hash/pg_crc.c?

Thanks, PFA patch v3.

--
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~?
Next
From: Daniel Gustafsson
Date:
Subject: Re: Detailed release notes