[PATCH] Remove workarounds to format [u]int64's - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject [PATCH] Remove workarounds to format [u]int64's
Date
Msg-id CAJ7c6TMSKi3Xs8h5MP38XOnQQpBLazJvVxVfPn++roitDJcR7g@mail.gmail.com
Whole thread Raw
Responses Re: [PATCH] Remove workarounds to format [u]int64's  (Pavel Borisov <pashkin.elfe@gmail.com>)
List pgsql-hackers
Hi hackers,

I learned from Tom [1] that we can simplify the code like:

```
char buff[32];
snprintf(buf, sizeof(buf), INT64_FORMAT, ...)
ereport(WARNING, (errmsg("%s ...", buf)));
```

... and rely on %lld/%llu now as long as we explicitly cast the
argument to long long int / unsigned long long. This was previously
addressed in 6a1cd8b9 and d914eb34, but I see more places where we
still use an old approach.

Suggested patch fixes this. Tested locally - no warnings; passes all the tests.

[1] https://www.postgresql.org/message-id/771048.1647528068%40sss.pgh.pa.us

-- 
Best regards,
Aleksander Alekseev

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: WIP: WAL prefetch (another approach)
Next
From: Pavel Borisov
Date:
Subject: Re: [PATCH] Remove workarounds to format [u]int64's