Hi Chao,
> "gd" is allocated by palloc0, so all members have been zero initialized, thus explicitly assigning NULL to the 4
membersis unnecessary. I don't think that has much runtime impact, but from a readability perspective, a potential
questionis that, "gd" has more fields, why only set 0 to these 4 members redundantly?
>
> To avoid the potential confusion, I think we'd better delete these initializations.
Good find. I agree that this code is redundant. Or alternatively we
should do palloc() and assign all the initial values explicitly.
--
Best regards,
Aleksander Alekseev