Re: Remove unneccessary memory initialization in planner.c - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: Remove unneccessary memory initialization in planner.c
Date
Msg-id CAJ7c6TM8g=z-v_qYFN5FWzWPUph=gTRvZWWyiDADN_7g5tZ6CQ@mail.gmail.com
Whole thread Raw
In response to Remove unneccessary memory initialization in planner.c  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Hi Chao,

> "gd" is allocated by palloc0, so all members have been zero initialized, thus explicitly assigning NULL to the 4
membersis unnecessary. I don't think that has much runtime impact, but from a readability perspective, a potential
questionis that, "gd" has more fields, why only set 0 to these 4 members redundantly? 
>
> To avoid the potential confusion, I think we'd better delete these initializations.

Good find. I agree that this code is redundant. Or alternatively we
should do palloc() and assign all the initial values explicitly.

--
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Amit Langote
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)