Re: [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope - Mailing list pgsql-hackers

From Tatsuya Kawata
Subject Re: [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope
Date
Msg-id CAHza6qdje-ub3AQVnbMdkn9d0DTFkN6x-nN99bjTXNSscTZJaw@mail.gmail.com
Whole thread
In response to Re: [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] doc: clarify pg_stat_lock.fastpath_exceeded scope
List pgsql-hackers
Hi Bertrand-san, Michael-san,

Thanks for the additional review!

> Looking closer, I'm not sure that in:
>
> -       lock table
> +       lock table.  See <xref linkend="locking-tables-fast-path"/> for
> +       details.
>
> the "for details" is needed. Looking at the pg_locks table, it looks like
> "(See xxxx)" would be more consistent.

Fixed.


> I am wondering if the paragraph in view-pg-locks could be
> improved and/or shortened with what you are proposing here, even if
> most of it points to the inconsistencies one could get when querying
> pg_locks due to the volatile nature of fast-path locks...  At least a
> link on the pg_locks page pointing to this new section could be
> something to consider.

Thanks for the detailed thought.  I looked at that paragraph.  I was
hoping to fold the two together, but the content did not seem to
overlap, so I limited the change to adding a link as you suggested.

v4 attached.

Regards,
Tatsuya Kawata

Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Small patch to improve safety of utf8_to_unicode().
Next
From: Peter Eisentraut
Date:
Subject: Re: Move FOR PORTION OF checks out of analysis