Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE - Mailing list pgsql-hackers

From Tatsuya Kawata
Subject Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
Date
Msg-id CAHza6qdibhqf17uuAUZ_w67Q3U9a4-nGYCkseLYiRWGF0tDhrg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
List pgsql-hackers
Hi Sawada-san and Chao-san,

Thank you both for your continued reviews and feedback on this patch.I agree with both points that could be misleading.
I've updated the message as follows:

memory usage: dead item storage %.2f MB accumulated across %d resets (limit %.2f MB each)

This wording:
- Use both "memory usage:" prefix  and "dead item storage" to be consistent with other existing log lines (buffer usage:, WAL usage:, system usage:) and to clarify what kind of memory we're reporting
- Clearly indicate that the value is a cumulative sum of snapshots, not actual memory allocation
- Use "across %d resets" to show the relationship between the accumulated value and reset count
- Keep "limit %.2f MB each" to indicate the per-reset memory limit

Please find attached the v11 patch.

Regards,
Tatsuya Kawata

Attachment

pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded
Next
From: Chao Li
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded