Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE - Mailing list pgsql-hackers

From Tatsuya Kawata
Subject Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
Date
Msg-id CAHza6qd2AUfezWX3HNEqop7-Na2GCMy4GgRJOu1LtvYCc5ha-A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Hi Sawada-san and Chao-san,

Thank you both for your continued reviews and feedback on this patch.

> The patch mostly looks good to me. I've made some cosmetic changes to
>   the comments  (as well as the commit message) and attached the updated
>   patch. Please review it.
Thank you. I have no objections.


> My last nitpick on v9:

>   ```
>   +                       appendStringInfo(&buf,
>   +                                                        ngettext("memory usage: %.2f MB in total, with dead-item storage reset %d time (limit was %.2f MB)\n",
>   +                                                                         "memory usage: %.2f MB in total, with dead-item storage reset %d times (limit was %.2f MB)\n",
>   ```

>   Instead of “dead-item”, I would suggest “dead item” (without dash), because in the existing code use “dead item”, for example:

>   ```
I've addressed your feedback.

Attached is v10 with these changes incorporated.
I really appreciate reviewing this patch throughout the iterations.

Regards,
Tatsuya Kawata
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Change some Datum to void * for opaque pass-through pointer
Next
From: Tatsuo Ishii
Date:
Subject: Re: Row pattern recognition