Hi David,
Thank you for the review!
> Can you prepare an initial patch that swaps tuplestore_end() for
> tuplestore_clear() in the relevant locations (similar to what
> 908a96861 did). This can go in separately on the justification that
> it's an optimisation to avoid the reallocation of fields that are
> pfree'd in tuplestore_end().
Sure! Happy to work on this. I'll prepare a separate patch and
post it once it's ready.
> I'll look at doing this for nodeMaterial.c. It might be somewhat
> harder to get a plan with a parameterised Material node, however, but
> it should be possible.
I noticed you've already posted the nodeMaterial.c patch [1], so I'll
use it as a reference.
Regards,
Tatsuya Kawata
[1]
https://www.postgresql.org/message-id/flat/CAApHDvoa55vcRth05Ozu5be4FawgTH-aCsZ5%3DZ%2B_UXTUzUxdQg%40mail.gmail.com
