Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. - Mailing list pgsql-hackers

On Thu, Mar 20, 2025 at 9:37 AM vignesh C <vignesh21@gmail.com> wrote:
>
> On Thu, 20 Mar 2025 at 09:06, Shubham Khanna
> <khannashubham1197@gmail.com> wrote:
> >
> > The attached patch contains the suggested changes.
>
> Couple of minor comments:
> 1) The second and third line comments can be in same line:
> +# Create user-defined publications, wait for streaming replication to sync them
> +# to the standby, then verify that '--remove'
> +# removes them.
>

Fixed.

> 2) This comment can be in a single line:
> +# In passing, also test the --enable-two-phase option and
> +# --remove option
>

Fixed.

The attached patch contains the suggested changes.

Thanks and regards,
Shubham Khanna.