Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document - Mailing list pgsql-hackers

On Fri, Nov 17, 2023 at 4:55 AM shihao zhong <zhong950419@gmail.com> wrote:
>
> Hi Jian,
>
> Thanks for your comments, a new version is attached.
>
> Thanks,
> Shihao
>
> On Fri, Nov 10, 2023 at 9:59 AM jian he <jian.universality@gmail.com> wrote:
>>
>> On Wed, Nov 1, 2023 at 10:30 AM shihao zhong <zhong950419@gmail.com> wrote:
>> >
>> > Thank you for your feedback on my previous patch. I have fixed the issue and attached a new patch for your review.
Couldyou please take a look for it if you have a sec? Thanks 
>> >
>>
>> Your patch works fine. you can see it here:
>> https://cirrus-ci.com/task/6481922939944960
>> in an ideal world, since the doc is already built, we can probably
>> view it as a plain html file just click the ci test result.
>>
>> in src/sgml/ref/create_table.sgml:
>> "Each exclude_element can optionally specify an operator class and/or
>> ordering options; these are described fully under CREATE INDEX."
>>
>> You may need to update this sentence to reflect that exclude_element
>> can also optionally specify collation.

I have reviewed the changes and it looks fine.

Thanks and Regards,
Shubham Khanna.