Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. - Mailing list pgsql-hackers

On Thu, Mar 6, 2025 at 9:18 AM Ajin Cherian <itsajin@gmail.com> wrote:
>
> On Fri, Feb 28, 2025 at 11:34 PM Shubham Khanna
> <khannashubham1197@gmail.com> wrote:
> >
> >
> > The attached Patch contains the suggested changes.
> >
> > Thanks and regards,
> > Shubham Khanna.
>
> Some comments:
> 1.
> +    <varlistentry>
> +     <term><option>-a</option></term>
> +     <term><option>--all</option></term>
> +     <listitem>
> +      <para>
> +       For all source server non-template databases create subscriptions for
> +       create subscriptions for databases with the same names on the
> +       target server.
> +       Subscription names, publication names, and replication slot names are
> +       automatically generated. Cannot be used together with
> +       <option>--database</option>, <option>--publication</option>,
> +       <option>--replication-slot</option> or <option>--subscription</option>.
>
> Don't start the sentence with "Cannot". Change the sentence to "This
> option cannot be used together with ..."
> similar sentences used in 3 other places below this as well. Change all of them.
>

Fixed.

> 2.
> +# Verify that only user databases got subscriptions (not template databases)
>
> change to "Verify that only user databases have subscriptions"
>

Fixed.

The attached patch contains the suggested changes.

Thanks and regards,
Shubham Khanna.