Hi Shlok.
Here are the remainder of my review comments for patch v3-0001.
These are for the test code only.
======
src/test/regress/sql/publication.sql
Missing Test case:
1.
AFAICT, there are currently no test cases for ALTER PUBLICATION that
are using variations of the syntax having multiple TABLE keywords.
e.g. "EXCEPT (TABLE t1,t2,t3, TABLE t4)".
IOW, the flexible syntax is being tested for CREATE PUBLICATION, but
not for ALTER PUBLICATION.
~~~
2.
--- Replace the existing EXCEPT TABLE list (testpub_tbl1) with a new
--- EXCEPT TABLE list containing only (testpub_tbl2).
-ALTER PUBLICATION testpub_foralltables_excepttable SET ALL TABLES
EXCEPT TABLE (testpub_tbl2);
+-- Replace the existing table list in EXCEPT clause (testpub_tbl1) with a new
+-- table list containing only (testpub_tbl2).
+ALTER PUBLICATION testpub_foralltables_excepttable SET ALL TABLES
EXCEPT (TABLE testpub_tbl2);
The comment seems wrong because, IIUC, the existing exclude-list at
this point would be "(TABLE testpub_tbl1, testpub_tbl2, TABLE
testpub_tbl3)".
Also /in EXCEPT clause/in the EXCEPT clause/
======
Kind Regards,
Peter Smith.
Fujitsu Australia
