Hi Sawada-San.
Here are some review comments for the v3-0001 test code.
======
src/test/regress/expected/publication.out
1.
+-- Clean up
+DROP FUNCTION test_gpt(text[], relname);
+ERROR: type "relname" does not exist
This seems a mistake. If the DROP FUNCTION was differently written
there there would be no error. PSA.
======
src/test/regress/sql/publication.sql
2.
+SELECT * FROM test_gpt('pub_normal', 'tbl_normal');
+SELECT * FROM test_gpt('pub_schema', 'tbl_normal'); -- no result
These tests seem strangely different from all the others because
everything else has both a "good result" test and a "no result" test
for every publication.
So I think there should be a "no result" test for 'pub_normal'
So I think there should be a "good result" test for 'pub_schema'
~~~
3.
Consider renaming that 'tbl_parent' to something like 'tbl_root'.
because 'parent' always makes me think of INHERITED parent/child
tables, rather than partitioned tables and their partitions. If you do
this, then you might also want to tweak several publication names --
e.g. 'pub_part_parent' -> 'pub_part_root'
~~~
PSA a diff file that makes those suggested changes #1 and #2.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
