Hi Shlok.
Some review comments for patch v27-0001.
======
doc/src/sgml/ref/alter_publication.sgml
1.
+ <para>
+ The <literal>RESET</literal> clause will reset the publication to
the default
+ state. This includes resetting all publication parameters, setting the
+ <literal>ALL TABLES</literal> and <literal>ALL SEQUENCES</literal> flags to
+ <literal>false</literal>, and removing all associated tables and
schemas from
+ the publication.
</para>
It would be better to give references to the actual
pg_publication.puballtables and .puballsequences flag fields [1]
instead of vaguely calling them the "<literal>ALL TABLES</literal> and
<literal>ALL SEQUENCES</literal> flags".
======
src/backend/commands/publicationcmds.c
AlterPublicationReset:
2.
+ if (pubform->puballtables)
+ CacheInvalidateRelcacheAll();
Does that also need to check ->puballsequences?
======
src/test/regress/sql/publication.sql
3.
If you want to, you can easily combine many of these test cases and
verify them in one go instead of separate ALTER/RESET for every kind
of flag.
~~~
4.
+-- Verify that 'ALL TABLES' flag is reset
Missing test to check the 'ALL SEQUENCES' flag gets reset?
======
[1] https://www.postgresql.org/docs/devel/catalog-pg-publication.html
Kind Regards,
Peter Smith.
Fujitsu Australia.
